Drop -dirty suffix; fetch tags on Vercel for clean version display#29
Merged
Conversation
The deployed site was showing "<sha>-dirty" because Vercel's shallow clone has no tags (so `git describe --tags` falls back to a SHA) and something during the Vercel build mutates a tracked file (npm install auto-runs and rewrites package-lock). - Remove --dirty from `git describe` in build.py: -dirty on a CI checkout reflects build-time mutations, not the source the user is looking at — never useful to surface. - Prepend `git fetch --tags --depth=1 origin || true` to Vercel's buildCommand so tags are visible to `git describe`. - Update test_dirty_tree to assert the suffix is suppressed. - Update CLAUDE.md file-map note. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The PRD originally framed -dirty as a "not-from-a-clean-tag" signal, but on Vercel every build is dirty (npm install rewrites package-lock during the build), so the signal was noise. This commit aligns the doc with the behavior change in the rest of this PR. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deployed site shows `d30e5b7-dirty` instead of a real tag. Two causes:
Fix:
Test plan
🤖 Generated with Claude Code