Resolve version via ls-remote when local tag refs are missing#32
Merged
Conversation
Vercel's shallow clone + `git fetch --tags --depth=1` doesn't reliably connect tag refs to HEAD's commit, so even when origin holds a tag that points exactly at HEAD, `git describe --tags` falls through to the short SHA — and the footer shows a commit hash instead of vX.Y.Z. Add an ls-remote fallback to resolve_version(): if local describe can't find an exact-match tag, ask origin directly. ls-remote works in any clone state because it's a remote query, not a local walk. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_version()now tries localgit describe --exact-match --tagsfirst, then falls back togit ls-remote --tags originto find a tag at HEAD, then togit describe --tags --always.Why
After PR #31 the deploy hook reliably builds the tagged commit, but the footer still showed a SHA (
73bb0ddfor v0.10.6). Vercel's shallow clone plusgit fetch --tags --depth=1doesn't reliably connect tag refs to HEAD's commit, sogit describe --tagswalked off the end and returned the short SHA.ls-remotequeries origin directly, so it works regardless of local clone state.Test plan
python3 -m unittest discover -s test/build(6 tests pass).python3 build.py --checkclean.vX.Y.Ztag.🤖 Generated with Claude Code