Update ash to main branch.#11
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Vulkan integration to work against newer ash APIs by switching the color-converter path from descriptor sets to VK_EXT_descriptor_buffer. In the codebase, that primarily affects device initialization and the compute-based RGB→YUV conversion pipeline.
Changes:
- Enable
VK_EXT_descriptor_bufferand descriptor-buffer-related device features during Vulkan device creation. - Replace converter descriptor pool/set allocation with a host-visible descriptor buffer.
- Rewrite
ColorConverter::convert()to populate and bind descriptor-buffer data at dispatch time.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
src/vulkan.rs |
Enables descriptor-buffer extension/feature chaining during logical-device creation. |
src/converter/pipeline.rs |
Reworks converter setup to use a descriptor-buffer-backed layout and buffer allocation instead of descriptor sets. |
src/converter/mod.rs |
Replaces per-frame descriptor-set updates with descriptor capture/buffer writes and descriptor-buffer binding in convert(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.