Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds experimental HDR-oriented plumbing by extending the RGB→YUV conversion pipeline with BT.709/BT.2020 matrix selection and adding encoder-side color/VUI signaling hooks, alongside more verbose Vulkan device selection diagnostics.
Changes:
- Add
ColorSpace+ new RGB input formats (ABGR2101010, RGBA16F) and passcolor_spacevia push constants to the converter shader. - Introduce
ColorDescriptionand plumb optional color signaling into H.264/H.265/AV1 session parameter initialization. - Improve Vulkan physical device selection logging and error messaging when no suitable Vulkan Video device is found.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/vulkan.rs |
Adds detailed per-device skip logging and expands the “no suitable device” error message. |
src/lib.rs |
Re-exports newly introduced color-related types from converter and encoder. |
src/encoder/mod.rs |
Introduces ColorDescription and adds EncodeConfig::color_description + builder method. |
src/encoder/h265/init.rs |
Wires optional VUI presence + fields into H.265 SPS creation. |
src/encoder/h264/init.rs |
Uses EncodeConfig::color_description to populate H.264 VUI color fields. |
src/encoder/av1/init.rs |
Maps ColorDescription into AV1 color config enums and flags. |
src/converter/shader.rs |
Updates shader to support BT.709/BT.2020 matrices and adds RGBA16F→PQ handling. |
src/converter/pipeline.rs |
Increases push constant range size to include color_space. |
src/converter/mod.rs |
Adds ColorSpace, new InputFormats, vk_format(), and pushes color_space to the shader. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.