Now resends verification email for account recovery#674
Merged
joshi1983 merged 1 commit intohhaccessibility:masterfrom Aug 1, 2018
Merged
Now resends verification email for account recovery#674joshi1983 merged 1 commit intohhaccessibility:masterfrom
joshi1983 merged 1 commit intohhaccessibility:masterfrom
Conversation
joshi1983
reviewed
Aug 7, 2018
| return view('pages.password_recovery.unmatched_email'); | ||
| } | ||
|
|
||
| if( $matching_user->email_verification_time == null) { |
Collaborator
There was a problem hiding this comment.
This if-statement breaks the code styling tests. I'm about to make a separate pull request to fix the problem.
Please run "composer all" every time you make a pull request or update one.
joshi1983
reviewed
Aug 16, 2018
|
|
||
| if( $matching_user->email_verification_time == null) { | ||
| $confirmationLink = BaseUser::generateConfirmationLink($matching_user); | ||
| Mail::send(new ConfirmationMail( |
Collaborator
There was a problem hiding this comment.
Where is ConfirmationMail defined? I guess you want it to be the one from App\Mail\ConfirmationMail but since that's not mentioned in the use statements, it is trying to find ConfirmationMail in App\Controllers namespace and failing.
Collaborator
There was a problem hiding this comment.
I created and merged pull request #682 to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #648