Add Dockerfile with linting and testing#36
Merged
Merged
Conversation
Container size is minimized by the ldflags (which strip debugging symbols) and compressing via upx.
hhatto
approved these changes
Jul 20, 2020
Owner
hhatto
left a comment
hhatto
left a comment
There was a problem hiding this comment.
LGTM
Thanks for your contribution 👍
Owner
|
I'll be uploading packages to Dockerhub and GitHub Packages in the near future. |
Contributor
Author
|
Ping: Any update on uploading the Docker Image to Dockerhub? |
Owner
|
@dbast I uploaded the package to GitHub Packages and Docker Hub. It's the same image for both. https://github.com/hhatto/gocloc/packages/350535 I'd be very grateful if you could let me know if there are any problems. Thanks |
Contributor
Author
|
Works, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container size is minimized by the ldflags (which strip debugging symbols) and compressing via upx.
After merging the PR, it would be nice if the dockerhub cloud builder could be activated to upload to image to Dockerhub for master=latest and $tags.
This then allows to use gocloc e.g. on CI via:
docker run -v ${PWD}:/workdir hhatto/gocloc .ordocker run -v ${PWD}:/workdir hhatto/gocloc:$VERSION .(instead of wget $release && $hashcheck && tar -xf .. && chmod +x .. && gocloc .).Thanks!