Changed ref type to GitReferenceType#72
Merged
BarabanovVVl merged 2 commits intomasterfrom Mar 6, 2025
Merged
Conversation
timbaev
reviewed
Mar 6, 2025
Comment on lines
+19
to
+27
| var nameValue: String { | ||
| switch self { | ||
| case .tag(let name), .branch(let name): | ||
| return name | ||
|
|
||
| case .commit(let sha): | ||
| return sha | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Кажется, это не особо нужно
Comment on lines
+37
to
+46
| switch ref { | ||
| case .tag, .branch: | ||
| try shell("git clone --depth 1 -b \(ref.nameValue) \(gitRepositoryURL) \(repositoryPath)") | ||
|
|
||
| Log.debug("Checking out \(ref) branch...") | ||
| try shell("cd \(repositoryPath) && git checkout \(ref)") | ||
| case .commit: | ||
| try shell("git clone \(gitRepositoryURL) \(repositoryPath)") | ||
|
|
||
| Log.debug("Checking out \(ref.nameValue) branch...") | ||
| try shell("cd \(repositoryPath) && git checkout \(ref.nameValue)") | ||
| } |
Collaborator
There was a problem hiding this comment.
Потому что здесь можно сразу получить и так значения:
switch ref {
case .tag(let name), .branch(let name):
try shell("git clone --depth 1 --branch \(name) \(gitRepositoryURL) \(repositoryPath)")
case .commit(let sha):
try shell("git clone \(gitRepositoryURL) \(repositoryPath)")
Log.debug("Checking out to \(sha) commit...")
try shell("cd \(repositoryPath) && git checkout \(sha)")
}
timbaev
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed cloning of the specified branch