Rework the init files and configs#8
Rework the init files and configs#8karbowiak wants to merge 7 commits intohhvm:masterfrom karbowiak:master
Conversation
… be set, otherwise it tries to scan /)
…ys a fastcgi server, why give the ability to screw that up?
…the hhvm init file
|
Some thoughts on my side.
I agree. I separate file has it advantage. See #9.
Disagree. Settings like 'RUN_AS_USER', 'CONFIG_FILE' and 'ADDITIONAL_ARGS' can not be set/overwritten the hdf conf. This is useful when customizing the startup. Take a look at
Disagree. You are using tabs, which is not recommend according to https://lists.debian.org/debian-devel/2012/03/msg00052.html
No sure hhvm.hdf is a clear name. See my recommendation notes below.
Please squash the commits -> http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html PS: I recommend to use separate git branches for every PR. My vote: Don't merge. Opened issue #9 to discuss the introduction of a separate config file for FastCGI. |
|
Coolio, i'll close this PR, and look at fixing the issues, then retry and issue a new PR :) |
Overall, a bit easier to work with, even if the PR looks garbled :(
Hopefully @dol is ok with me reworking his init