Skip to content

Conversation

@Atry
Copy link
Contributor

@Atry Atry commented Feb 14, 2022

According to https://github.com/hhvm/hh-apidoc/releases/tag/v0.8.0 , hh-apidoc is not backward compatible with 0.6.0.

@fredemmott
Copy link
Contributor

Change is good, however:

This PR should fix the nightly CI

There is a lock file; this should be an unobservable change by itself. It should have no effect on CI, and the failure appears unrelated.

@fredemmott
Copy link
Contributor

FAILED: build/extracted-examples/api/hack/class.AsyncMysqlQueryResult.method.vectorRowsTyped/basic-usage.hack
[10](https://github.com/hhvm/user-documentation/runs/5186482140?check_suite_focus=true#step:6:10)
invalid skipif output 'skipterminate called after throwing an instance of 'std::system_error'
[11](https://github.com/hhvm/user-documentation/runs/5186482140?check_suite_focus=true#step:6:11)
  what():  pthread_setspecific failed: Invalid argument'

This is an intermittent environment issue or HHVM bug, not a Hack library compatibility one.

@Atry Atry merged commit 64393fe into hhvm:main Feb 14, 2022
@Atry Atry deleted the hh-apidoc-0.7 branch February 14, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants