Skip to content

query parser improvements #10191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

query parser improvements #10191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa3d2fe
much better error when query has 'having' but no 'group by'
gavinking May 21, 2025
2710ad9
extract trivial convenience methods
gavinking May 21, 2025
24df897
cleanups and type safety in SemanticQueryBuilder
gavinking May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions hibernate-core/src/main/antlr/org/hibernate/grammars/hql/HqlParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,14 @@ limitOffset
*
* - The 'select' clause may come first, in which case 'from' is optional
* - The 'from' clause may come first, in which case 'select' is optional, and comes last
* - If both 'select' and 'from' are missing, a 'where' clause on its own is allowed
*
* Note that 'having' is only allowed with 'group by', but we don't enforce
* that in the grammar.
*/
query
// TODO: add with clause
: selectClause fromClause? whereClause? (groupByClause havingClause?)?
| fromClause whereClause? (groupByClause havingClause?)? selectClause?
: selectClause fromClause? whereClause? groupByClause? havingClause?
| fromClause whereClause? groupByClause? havingClause? selectClause?
| whereClause
;

Expand Down
Loading
Loading