Skip to content

eliminate some unnecessary overrides in JavaTypes #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gavinking merged 1 commit into from
Dec 5, 2025
Merged

eliminate some unnecessary overrides in JavaTypes #11395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BasicJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ default JdbcType getRecommendedJdbcType(JdbcTypeIndicators indicators) {

@Override
default T fromString(CharSequence string) {
throw new UnsupportedOperationException();
throw new UnsupportedOperationException( "Type " + getTypeName()
+ " does not support conversion from String");
}
}
2 changes: 1 addition & 1 deletion hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarDateJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public String toString(Calendar value) {
}

public Calendar fromString(CharSequence string) {
Calendar result = new GregorianCalendar();
final var result = new GregorianCalendar();
result.setTime( JdbcDateJavaType.INSTANCE.fromString( string.toString() ) );
return result;
}
Expand Down
2 changes: 1 addition & 1 deletion hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public String toString(Calendar value) {
}

public Calendar fromString(CharSequence string) {
Calendar result = new GregorianCalendar();
final var result = new GregorianCalendar();
result.setTime( DateJavaType.INSTANCE.fromString( string.toString() ) );
return result;
}
Expand Down
2 changes: 1 addition & 1 deletion hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarTimeJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public String toString(Calendar value) {
}

public Calendar fromString(CharSequence string) {
Calendar result = new GregorianCalendar();
final var result = new GregorianCalendar();
result.setTime( JdbcTimeJavaType.INSTANCE.fromString( string.toString() ) );
return result;
}
Expand Down
12 changes: 0 additions & 12 deletions ...ore/src/main/java/org/hibernate/type/descriptor/java/spi/EmbeddableAggregateJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,6 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {
);
}

@Override
public String toString(T value) {
return value.toString();
}

@Override
public T fromString(CharSequence string) {
throw new UnsupportedOperationException(
"Conversion from String strategy not known for this Java type: " + getTypeName()
);
}

@Override
public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
if ( type.isAssignableFrom( getJavaTypeClass() ) ) {
Expand Down
15 changes: 2 additions & 13 deletions hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/EntityJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import org.hibernate.type.descriptor.jdbc.JdbcType;
import org.hibernate.type.descriptor.jdbc.JdbcTypeIndicators;

import static java.lang.System.identityHashCode;
import static org.hibernate.proxy.HibernateProxy.extractLazyInitializer;

/**
Expand All @@ -36,7 +37,7 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {

@Override
public int extractHashCode(T value) {
return System.identityHashCode( value );
return identityHashCode( value );
}

@Override
Expand All @@ -57,18 +58,6 @@ public boolean isInstance(Object value) {
}
}

@Override
public String toString(T value) {
return value.toString();
}

@Override
public T fromString(CharSequence string) {
throw new UnsupportedOperationException(
"Conversion from String strategy not known for this Java type: " + getTypeName()
);
}

@Override @SuppressWarnings("unchecked") // safe, we do check
public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
final var id =
Expand Down
12 changes: 0 additions & 12 deletions ...rnate-core/src/main/java/org/hibernate/type/descriptor/java/spi/JavaTypeBasicAdaptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,6 @@ public boolean useObjectEqualsHashCode() {
return true;
}

@Override
public String toString(T value) {
return value.toString();
}

@Override
public T fromString(CharSequence string) {
throw new UnsupportedOperationException(
"Conversion from String strategy not known for this Java type: " + getTypeName()
);
}

@Override
public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
throw new UnsupportedOperationException(
Expand Down
5 changes: 0 additions & 5 deletions hibernate-core/src/main/java/org/hibernate/type/descriptor/java/spi/MapEntryJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {
throw new UnsupportedOperationException( "Unsupported attempt to resolve JDBC type for Map.Entry" );
}

@Override
public Map.Entry fromString(CharSequence string) {
throw new UnsupportedOperationException( "Unsupported attempt create Map.Entry from String" );
}

@Override
public <X> X unwrap(Map.Entry value, Class<X> type, WrapperOptions options) {
throw new UnsupportedOperationException( "Unsupported attempt to unwrap Map.Entry value" );
Expand Down
12 changes: 0 additions & 12 deletions ...rnate-core/src/main/java/org/hibernate/type/descriptor/java/spi/UnknownBasicJavaType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,6 @@ public JdbcType getRecommendedJdbcType(JdbcTypeIndicators context) {
);
}

@Override
public String toString(T value) {
return value.toString();
}

@Override
public T fromString(CharSequence string) {
throw new UnsupportedOperationException(
"Conversion from String strategy not known for this Java type: " + getTypeName()
);
}

@Override
public <X> X unwrap(T value, Class<X> type, WrapperOptions options) {
if ( type.isAssignableFrom( getJavaTypeClass() ) ) {
Expand Down
Loading