Skip to content

Backport ByteBuddy fixes to 5.3 #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Backport ByteBuddy fixes to 5.3 #2752

wants to merge 13 commits into from

Conversation

@gsmet
Copy link
Member

@gsmet gsmet commented Jan 23, 2019 •
edited
Loading

This PR fixes 2 things:

  • the fact that all the classes were rewritten even if not enhanced (i.e. when the class was not enhanced, it was still rewritten anyway which generates quite a lot of useless I/O);
  • we had a lot of performance issues with the ByteBuddy implementation mostly related to memory allocation (we allocated a lot of objects due to DSL usage).

This is all fixed by this set of patches.

It also includes the commit from #2750 (so let's wait for this PR to be merged before merging this one).

Sanne and others added 11 commits January 29, 2019 15:25
@Sanne @gsmet
HHH-13099 Update to Byte Buddy 1.9.4
bd0ab2d
@Sanne @gsmet
HHH-13100 All custom implementation of Byte Buddy "Implementation" s …
553508a 
…should have a proper equals and hashcode
@gsmet
HHH-13097 Add a missing @OverRide
cc9ab4c
@gsmet
HHH-13097 Only rewrite class if enhanced in the ByteBuddy enhancer
b778019 
This makes the behavior of the ByteBuddy enhancer consistent with the
behavior of the Javassist enhancer.

Currently, the Maven plugin rewrites every class provided.
@gsmet
HHH-13097 Cache the annotations resolution
0943e95
@gsmet
HHH-13097 Cache the resolution of the getters
18303e1
@gsmet
HHH-13097 Cache a static ByteBuddy matcher
ad41276
@gsmet
HHH-13097 Don't throw an exception if there are two getter candidates
a1e7b07
@gsmet
HHH-13100 Make a couple of equals()/hashCode() implementations lighter
5941fef
@Sanne @gsmet
HHH-13100 Remove unused import
8a8b49a
@gsmet
HHH-13220 Only create the PersistentAttributeTransformer if the class…
9d9f528 
… is enhanced
@gsmet gsmet force-pushed the bytebuddy-backports-5.3 branch from 2d9ab12 to 9d9f528 Compare January 29, 2019 14:37
@gsmet
Copy link
Member Author

gsmet commented Feb 21, 2019

This one has been merged.

@gsmet gsmet closed this Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

5.3 Ready for review Requires Gail

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gsmet @Sanne