HHH-7252 AbstractEntityManagerImpl.find() not throwing proper exception types for LockTimeout. #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Deadlock / lock timeout (not available with NOWAIT query).
The code was a bit non-obvious (assignment in a method call argument) where it was being done, and the local variable (lockOptions) assignment was missing in the find() method implementation. I changed all instances of lockOptions assignment to assign before the method call where it's required as an argument, ensuring proper scope for exception mapping.
…tly fails for PostgreSQL matrix tests, unless HHH-7251 is also applied.
… thrown. This feels sooo wrong. I know dialects aren't mapping lock exceptions properly, and this test case exposes that if you fail the test when PersistenceException is thrown. So what do I do now? There are other tests in this very test class that don't fail the build when the wrong exception is thrown, even though they clearly should.
… I was doing more than I needed to. Updated the LockTest to enable another nowait test for postgresql.
Member
|
For future reference, we do not merge master into topic branches. Merging creates ugly "merge commits" that make the project history go all spaghetti. I will try to fix this for this pull request... |
Member
|
Ok, I was able to weed out the merge commits. In the future, please use rebasing to keep your changes contiguous at the end of history. |
Contributor
Author
|
Sorry about that. I'm new to git... On Wed, May 2, 2012 at 6:37 PM, Steve Ebersole <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is only testable when the database dialects throw the proper Hibernate Exception type for SQL Errors generated by lock timeouts.
Unfortunately, adding this test case exposes that most of the database dialects in Hibernate are not mapping SQL Errors for timeouts properly.
There are a few exceptions.
I've been talking with sebersol on freenode the last few days about this, and was instructed to go ahead and make this pull request. If I had access to the RedHat test systems I would have already addressed these issues. I expect this request to cause some matrix tests to start failing. I will be happy to assist in fixing those (and the dialects which fail) if I can somehow get access to the logs for the failures (which should have the JDBCException dumps with the proper error states for each dialect).