Wip/6.0 HHH-13877 Make@SortNatural default for SortedSet and SortedMap

[NathanQingyangXu]

https://trello.com/c/up8I5oIi/58-support-for-sorted-set-and-sorted-map-without-sortnatural-or-sortcomparator

https://hibernate.atlassian.net/browse/HHH-13877

testing case added

[NathanQingyangXu]

I manually compared to explicit @SortNatural case and found everything is the same(only hadExplicitSort values are different but it is used internally in this method and its main usage is the above code snippet), so removing the above code snippet seems enough to achieve the goal of this PR, unless I were wrong.

[sebersole]

I need to look through this some more.

However, this would be a new feature or improvement since we did not previously support this. New features/improvements ought to have a corresponding Jira - the reason being it will be easier to consolidate all new features and improvements when we get to CRs and eventually Final

[sebersole]

We should also assert that the phones are in fact sorted in proper order.

[NathanQingyangXu]

Updated. Originally I had thought we might end up with testing SortedSet or SortedMap. Testing case enriched enormously.

[NathanQingyangXu]

It doesn't make sense to insert testing data with the natural order. Ideally we are supposed to populate big number of data to ensure the order is not maintained not by accident.

[NathanQingyangXu]

I need to look through this some more.

However, this would be a new feature or improvement since we did not previously support this. New features/improvements ought to have a corresponding Jira - the reason being it will be easier to consolidate all new features and improvements when we get to CRs and eventually Final

I created a ticket for this: https://hibernate.atlassian.net/browse/HHH-13877 and updated the PR accordingly.

[sebersole]

Looked through this some more and approve the changes.

However because of other "code cleanup" type changes a few files here now have completely unnecessary conflicts which is the problem I was pointing out a few weeks ago.

Anyway, please rebase these changes on top of those cosmetic cleanups. Thanks

[NathanQingyangXu]

Looked through this some more and approve the changes.

However because of other "code cleanup" type changes a few files here now have completely unnecessary conflicts which is the problem I was pointing out a few weeks ago.

Anyway, please rebase these changes on top of those cosmetic cleanups. Thanks

A lesson learned. Conflict resolved (mainly from another PR, but yeah, cosmetic code changes break other PRs easily) and force pushed.

[sebersole]

Thanks @NathanQingyangXu

I'll apply after the checks complete