-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-13925 Upgrade to Gradle 6.3 #3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erprise plugin That's the new name of the plugin in Gradle 6.
This wasn't detected by checkstyle in Gradle 5, but it is now, and that fails the build.
You're not supposed to use unescaped "<" or ">". This wasn't detected by checkstyle in Gradle 5, but it is now, and that fails the build.
Member
Author
|
Everything seems in order:
|
sebersole
reviewed
Apr 3, 2020
sebersole
previously requested changes
Apr 3, 2020
Member
sebersole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I thought it looks fine. I only looked closely through the main commit, skipping all of the "clean up" commits. I would like to see the headers changed as mentioned
Member
Author
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-13925
This is a preview: I ran the build locally to some extent, but I'd like a build from the CI. Also, I still need to run other builds, especially on JDK13 and 14, and to test publishing.=> Done (see comments)