Skip to content

Conversation

@yrodiere
Copy link
Member

@yrodiere yrodiere commented Apr 2, 2020

https://hibernate.atlassian.net/browse/HHH-13925

This is a preview: I ran the build locally to some extent, but I'd like a build from the CI. Also, I still need to run other builds, especially on JDK13 and 14, and to test publishing. => Done (see comments)

yrodiere added 5 commits April 2, 2020 16:40
…erprise plugin

That's the new name of the plugin in Gradle 6.
This wasn't detected by checkstyle in Gradle 5, but it is now, and that
fails the build.
You're not supposed to use unescaped "<" or ">".

This wasn't detected by checkstyle in Gradle 5, but it is now, and that
fails the build.
@yrodiere
Copy link
Member Author

yrodiere commented Apr 3, 2020

Everything seems in order:

@yrodiere yrodiere changed the title [Preview] HHH-13925 Upgrade to Gradle 6.3 HHH-13925 Upgrade to Gradle 6.3 Apr 3, 2020
@yrodiere yrodiere requested a review from sebersole April 3, 2020 12:54
Copy link
Member

@sebersole sebersole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I thought it looks fine. I only looked closely through the main commit, skipping all of the "clean up" commits. I would like to see the headers changed as mentioned

@yrodiere yrodiere dismissed sebersole’s stale review April 6, 2020 14:04

Quoting: "No problem then"

@yrodiere yrodiere merged commit 9bb76a5 into hibernate:master Apr 6, 2020
@yrodiere
Copy link
Member Author

yrodiere commented Apr 6, 2020

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants