HHH-13969 Fix handling of large varbinary in SybaseASE15Dialect #3367
Conversation
| super(); | ||
|
|
||
| registerColumnType( Types.VARBINARY, "image" ); | ||
| registerColumnType( Types.VARBINARY, 8000, "varbinary($l)" ); |
There was a problem hiding this comment.
8000 is the max length for SQLServer. Should we use 32767 instead here?
There was a problem hiding this comment.
That's what I decided it should be for Sybase Anywhere. (But apparently for ASE it depends on the version.)
There was a problem hiding this comment.
Actually it also depends on the page size which can be as small as 2k.
There was a problem hiding this comment.
Yep, it's based on the database page size which is configurable.
On reflection, we should look up and use the actual page size instead of a fixed value of 8000.
I couldn't find a quick way to do this after looking through the other dialects.
Can you give any pointers to how this would be done? I would be happy to give that a go.
|
Sorry, I have zero experience on SyBase, but I guess there must be some way.
…On Mon, Sep 7, 2020 at 3:11 PM Noupoi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
hibernate-core/src/main/java/org/hibernate/dialect/SybaseASE15Dialect.java
<#3367 (comment)>
:
> @@ -30,6 +30,8 @@
public SybaseASE15Dialect() {
super();
+ registerColumnType( Types.VARBINARY, "image" );
+ registerColumnType( Types.VARBINARY, 8000, "varbinary($l)" );
Yep, it's based on the database page size which is configurable.
On reflection, we should look up and use the actual page size instead of a
fixed value of 8000.
I couldn't find a quick way to do this after looking through the other
dialects.
Can you give any pointers to how this would be done? I would be happy to
give that a go.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3367 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6UYAUNR5KOCXXVVWQSQVDSEUV5VANCNFSM4MORW2JA>
.
|
|
This is now handled differently, and the max is set to |
3 participants
https://hibernate.atlassian.net/browse/HHH-13969
Updates the handling of the VARBINARY type so when a using column size larger than what Sybase accepts, the
imagetype is used instead.This change mirrors the behaviour of other Transact-SQL dialects such as SQLServerDialect.
Document on
varbinary- size only goes up to 16K:https://wiki.ispirer.com/sqlways/sybase/data-types/varbinary
Document on the
imagetype:https://wiki.ispirer.com/sqlways/sybase/data-types/image