get rid of ugly message

[gavinking]

and refresh code in ExceptionConverterImpl

[hibernate-github-bot]

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [8a066a3]

› This message was automatically generated.

[dreab8]

Hi @gavinking,

I'm not sure why we are returning a RollbackException but I think it is not correct so I created #5247
what do you think?

[gavinking]

Um where precisely? Did I mess up?

[dreab8]

no you don't I think it was messed up, I believe but I may be wrong that it is not quite correct to always throw a RollbackException when converting a commit exception.

[gavinking]

Ah Ok i will take a closer look when I get back home.

[gavinking]

@dreadb8 I might be wrong, but the existing behavior looks correct-ish to me.

The spec says:

The RollbackException is thrown by the persistence provider when EntityTransaction.commit fails.

and the Javadoc for Transaction.commit() saysL

@throws RollbackException if the commit fails

which looks like what the code does currently.

Why do you think it's wrong?

[dreab8]

ok, so just my bad interpretation of the RollbackException, sorry for the noise :( and thanks for the explanation :)

[gavinking]

OK, cool 👍