HHH-16403 Avoid unnecessary wrapping for exceptions/errors thrown by getters/setters #6329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
approved these changes
Apr 4, 2023
Member
|
Please backport that to 6.2 |
Member
Author
|
@beikov Why? That's an improvement and a behavior change, it doesn't fix a regression in ORM 6. |
Member
|
Ok, if you feel like this has the potential for being a breaking change. To me, this is more of a bug fix i.e. we should never wrap errors anywhere |
Member
Author
I just saw code translating any exception coming from Hibernate as a HTTP 400 (bad request) in their Jax-RS layer, so... I'm afraid everything is possible at this point :/ Let's backport if someone actually experiences this problem in a real application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-16403