HHH-17463 UnsupportedOperationException when using JAKARTA_JDBC_URL

[dreab8]

https://hibernate.atlassian.net/browse/HHH-17463

[beikov]

Maybe I'm missing something, but shouldn't the JAKARTA_JDBC_URL etc. be normalized like the other properties in org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl#normalizeDataAccess? I feel like this approach is tackling the problem from the wrong angle.

[dreab8]

In this case SessionFactoryBuilderImpl is used and not EntityManagerFactoryBuilderImpl.

[beikov]

IMO SessionFactoryBuilderImpl should normalize the settings similar to how EntityManagerFactoryBuilderImpl does it, so that the connection provider implementation don't have to take care of that.

[dreab8]

Unfortunately it's too late, the DriverManagerConnectionProviderImpl builds the ConnectionCreator passing the configurations values before the construction of the SessionFactory

[beikov]

IMO the org.hibernate.cfg.Configuration#buildSessionFactory() should do all of this config property merging into the standardServiceRegistryBuilder#getSettings() before the ServiceRegistry is built.

[beikov]

Note that https://discourse.hibernate.org/t/deprecated-settings-necessary-for-bootstrapping/8678 runs into that exact issue.

[beikov]

Superseded by #7613