Skip to content

Conversation

@gtoison
Copy link
Contributor

@gtoison gtoison commented Oct 25, 2024

HHH-18770 Run the autoflush test without enabling JFR


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@gtoison gtoison marked this pull request as draft October 25, 2024 15:32
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 27, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

When the JFR partial flush event is disabled (for instance when JFR is
entirely disabled) beginPartialFlushEvent() will return a null event.
@gtoison gtoison changed the title HHH-18770 Issue reproducer HHH-18770 NPE when using the JFR integration with JFR disabled Oct 28, 2024
@gtoison gtoison marked this pull request as ready for review October 28, 2024 06:41
@dreab8
Copy link
Member

dreab8 commented Oct 29, 2024

Hi @gtoison ,

thanks for you PR I created a new one based on your change. I have done some code refactoring and simplified the check, it's enough to check that hibernateMonitoringEvent is not null.

Superseded by #9180

@dreab8 dreab8 closed this Oct 29, 2024
@gtoison
Copy link
Contributor Author

gtoison commented Oct 29, 2024

Thank you for looking into it Andrea!

@dreab8
Copy link
Member

dreab8 commented Oct 29, 2024

Thanks to you for the reproducer and the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants