HHH-19104 Envers - Reset ReflectionTools cache on disintegration #9699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
approved these changes
Feb 6, 2025
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Makes sense to me, thanks!
I also would appreciate if we could backport to 6.6 (it applies cleanly).
Can you open a PR to 6.6? It'll run all tests on CI -- including against Quarkus 3.15 -- and after we merge it, it'll get released automatically over the weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully fix https://hibernate.atlassian.net/browse/HHH-19104 by clearing the caches in
ReflectionToolswhen disintegrating Envers.Note that it has been a while since my last contribution here so let me know if things need to be adjusted.
I also would appreciate if we could backport to 6.6 (it applies cleanly).
Initially reported here: quarkusio/quarkus#46102.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.