Skip to content

promote getSession() up to PersistentCollection #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

promote getSession() up to PersistentCollection #9776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions hibernate-core/src/main/java/org/hibernate/collection/spi/AbstractPersistentCollection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,11 +897,7 @@ public void afterRowInsert(CollectionPersister persister, Object entry, int i) t
@Override
public abstract Collection<E> getOrphans(Serializable snapshot, String entityName) throws HibernateException;

/**
* Get the session currently associated with this collection.
*
* @return The session
*/
@Override
public final SharedSessionContractImplementor getSession() {
return session;
}
Expand Down
6 changes: 3 additions & 3 deletions hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentArrayHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,9 @@ public boolean needsInserting(Object entry, int i, Type elemType) throws Hiberna
public boolean needsUpdating(Object entry, int i, Type elemType) throws HibernateException {
final Serializable sn = getSnapshot();
return i < Array.getLength( sn )
&& Array.get( sn, i ) != null
&& Array.get( array, i ) != null
&& elemType.isDirty( Array.get( array, i ), Array.get( sn, i ), getSession() );
&& Array.get( sn, i ) != null
&& Array.get( array, i ) != null
&& elemType.isDirty( Array.get( array, i ), Array.get( sn, i ), getSession() );
}

@Override
Expand Down
9 changes: 8 additions & 1 deletion hibernate-core/src/main/java/org/hibernate/collection/spi/PersistentCollection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import org.hibernate.HibernateException;
import org.hibernate.Incubating;
import org.hibernate.Internal;
import org.hibernate.engine.spi.InstanceIdentity;
import org.hibernate.engine.spi.SharedSessionContractImplementor;
import org.hibernate.metamodel.mapping.PluralAttributeMapping;
Expand Down Expand Up @@ -359,7 +360,6 @@ default boolean needsUpdating(
*
* @see #injectLoadedState
*/
@SuppressWarnings("UnusedReturnValue")
boolean endRead();

/**
Expand Down Expand Up @@ -511,6 +511,13 @@ default boolean isDirectlyProvidedCollection(Object collection) {

void initializeEmptyCollection(CollectionPersister persister);

/**
* Get the session currently associated with this collection.
* Declared here for use by Hibernate Reactive.
*/
@Internal
SharedSessionContractImplementor getSession();

/**
* Is the collection newly instantiated?
*
Expand Down
Loading