Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* SPDX-License-Identifier: LGPL-2.1-or-later
* Copyright Red Hat Inc. and Hibernate Authors
*/
package org.hibernate.engine.internal;

import org.hibernate.internal.log.SubSystemLogging;
import org.jboss.logging.BasicLogger;
import org.jboss.logging.Logger;
import org.jboss.logging.annotations.LogMessage;
import org.jboss.logging.annotations.Message;
import org.jboss.logging.annotations.MessageLogger;
import org.jboss.logging.annotations.ValidIdRange;

import java.lang.invoke.MethodHandles;

import static org.jboss.logging.Logger.Level.TRACE;

@MessageLogger(projectCode = "HHH")
@ValidIdRange(min=160000,max = 160100)
@SubSystemLogging(
name = VersionLogger.LOGGER_NAME,
description = "Logging related to versioning"
)
public interface VersionLogger extends BasicLogger {
String LOGGER_NAME = SubSystemLogging.BASE + ".versioning";
VersionLogger INSTANCE = Logger.getMessageLogger( MethodHandles.lookup(), VersionLogger.class, LOGGER_NAME );

@LogMessage(level = TRACE)
@Message(value = "Seeding version: %s", id = 160001)
void seed(Object seededVersion);
@LogMessage(level = TRACE)
@Message(value = "Using initial version: %s", id = 160002)
void initial(Object initialVersion);
@LogMessage(level = TRACE)
@Message(value = "Incrementing version: %s to: %s", id = 160003)
void incrementing(Object oldVersion, Object newVersion);
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@
package org.hibernate.engine.internal;

import org.hibernate.engine.spi.SharedSessionContractImplementor;
import org.hibernate.internal.CoreMessageLogger;
import org.hibernate.metamodel.mapping.EntityVersionMapping;
import org.hibernate.persister.entity.EntityPersister;
import org.hibernate.type.descriptor.java.VersionJavaType;

import org.jboss.logging.Logger;

import java.lang.invoke.MethodHandles;

import static org.hibernate.generator.EventType.INSERT;
import static org.hibernate.generator.EventType.UPDATE;
Expand All @@ -23,11 +20,7 @@
* @author Gavin King
*/
public final class Versioning {
private static final CoreMessageLogger LOG = Logger.getMessageLogger(
MethodHandles.lookup(),
CoreMessageLogger.class,
Versioning.class.getName()
);
private static final VersionLogger LOG = VersionLogger.INSTANCE;

/**
* Private constructor disallowing instantiation.
Expand All @@ -52,7 +45,7 @@ public static Object seed(EntityVersionMapping versionMapping, SharedSessionCont
versionMapping.getScale(),
session
);
LOG.tracef( "Seeding: %s", seed );
LOG.seed( seed );
return seed;
}

Expand Down Expand Up @@ -81,7 +74,7 @@ public static boolean seedVersion(
return true;
}
else {
LOG.tracev( "Using initial version: {0}", initialVersion );
LOG.initial( initialVersion );
return false;
}
}
Expand All @@ -100,7 +93,7 @@ public static boolean isNullInitialVersion(Object initialVersion) {
// and for "older" behavior where version number did not get
// seeded if it was already set in the object
// TODO: shift it into unsaved-value strategy
initialVersion instanceof Number && ((Number) initialVersion).longValue() < 0;
initialVersion instanceof Number number && number.longValue() < 0;
}

/**
Expand Down Expand Up @@ -142,13 +135,7 @@ public static Object increment(Object version, EntityVersionMapping versionMappi
versionMapping.getScale(),
session
);
if ( LOG.isTraceEnabled() ) {
LOG.tracef(
"Incrementing: %s to %s",
versionType.toString( version ),
versionType.toString( next )
);
}
LOG.incrementing( version, next );
return next;
}

Expand Down
Loading