Skip to content

Conversation

@dreab8
Copy link
Member

@dreab8 dreab8 commented Feb 25, 2025

https://hibernate.atlassian.net/browse/HHH-19179

The PR addresses the following commits

  • 50c12d9 , it cotyains only a test that has been removed

  • 816c976 ,
    removed only the test.
    Of the initial commit remains only

if ( copyCache.containsValue( original ) ) {
	cached = original;
}

that int the course of time has been refactored into

if ( copyCache.containsValue( original ) ) {
	retrun original;
}
  • 328fa23 ,
    The main change consist in change of signature of the CascadingActionsnoCascade methods, these two method were deprecated and this PR removes them

  • 7c2a588 , removed only test, the implementation seems trivial and plus the code has undergone further changes now it become

if ( isMappedBy ) {
   ...
}
 else if ( oneToMany
				&& property.hasDirectAnnotationUsage( OnDelete.class )
				&& !property.hasDirectAnnotationUsage( JoinColumn.class )
				&& !property.hasDirectAnnotationUsage( JoinColumns.class )) {
			throw new AnnotationException( "Unidirectional '@OneToMany' association '"
					+ qualify( propertyHolder.getPath(), propertyName )
					+ "' is annotated '@OnDelete' and must explicitly specify a '@JoinColumn'" );
		}
}
  • 4615ae1 , the main chainge is the Dialetc#buildLimitHandler(String RowSelection ) refactored into getLimitHandler() and the fact that limit handlers became singletons. It seems the change is how most of us would have implemented it.

  • fb15ee5 , tha mian change is the removing the Cascade constructor and make all its methods static in order to avoid creation of multiple Cascade object.
    It seems the change is how most of us would have implemented it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19178

@sebersole
Copy link
Member

the main chainge is the Dialetc#buildLimitHandler(String RowSelection ) refactored into getLimitHandler() and the fact that limit handlers became singletons. It seems the change is how most of us would have implemented it

And as we discussed its just reorganizing existing code

@sebersole
Copy link
Member

sebersole commented Feb 25, 2025

tha mian change is the removing the Cascade constructor and make all its methods static in order to avoid creation of multiple Cascade object.
It seems the change is how most of us would have implemented it.

I think this is also another case where its moving around existing code as above.

@dreab8 dreab8 force-pushed the HHH-19179 branch 2 times, most recently from a9ed853 to 306e6c9 Compare February 25, 2025 15:58
@dreab8
Copy link
Member Author

dreab8 commented Feb 26, 2025

we have the approval to change licence for 7c2a588

@sebersole
Copy link
Member

WRT 816c976, I reached out to the contributor on the commit to ask permission. Let's hold off to see if we get a reply. If not, we'll have to reevaluate that change.

@sebersole
Copy link
Member

WRT 816c976, I reached out to the contributor on the commit to ask permission. Let's hold off to see if we get a reply. If not, we'll have to reevaluate that change.

The contributor has yet to reply. I consider the change trivial, but like to have agreement even in such cases. But let's just move ahead with its triviality.

The rest look good.

@sebersole sebersole merged commit ad32bfe into hibernate:main Mar 1, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants