HHH-19181: Remove LGPL-only contributions - Batch 3 #9814
Conversation
…akur8-tech.com>
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
| final SqmPolymorphicRootDescriptor<R> unmappedPolymorphicDescriptor = (SqmPolymorphicRootDescriptor<R>) unmappedPolymorphicReference.getReferencedPathSource(); | ||
| final Set<EntityDomainType<? extends R>> implementors = unmappedPolymorphicDescriptor.getImplementors(); | ||
| final SqmPolymorphicRootDescriptor<?> unmappedPolymorphicDescriptor = (SqmPolymorphicRootDescriptor<?>) unmappedPolymorphicReference.getReferencedPathSource(); | ||
| final Set<EntityDomainType<?>> implementors = unmappedPolymorphicDescriptor.getImplementors(); |
There was a problem hiding this comment.
I wouldn’t say that we need to roll back such trivial things.
There was a problem hiding this comment.
To clarify, I would not necessarily say it is trivial. But I do think it is questionable whether the change is obvious and self-evident. I think given the request, this is how any of us would have implemented it.
And in fact, @beikov contributed much to the actual implementation - #7468 (comment)
Let's roll back this removal
Really, this change is simply marking the validation threads as daemons. The code had already used threads for this purpose. I think that marking those threads as daemons is self-evident. So to me, this becomes a question of whether we would have made changes differently. After numerous web searches, the pattern used here is exactly the approach recommended in places like Stackoverflow and blogs - so I'd have to say no, this is a non-novel solution. |
|
@koentsje You want to rework the PR per those comments? I can if you prefer, just let me know. |
|
See #9826 for alternative keeping just the 330d2fb commit from here which removes
|
|
Going with my PR for now as I have not heard back and want to get this moving along. We can looking at cherry-picking any of these other removals later if we deem it necessary |
3 participants
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.