HV-1975 Remove Security Manager usage #1345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
remove-security-manager
branch
from
4a026bc to
3ed40d6
Compare
|
I'm probably +1 on this one but we need to make sure we won't have to update HV to this version in a component that still requires Security Manager support. |
|
Agreed on the intent, but this is a feature removal and thus needs to be in the next major version. We'll need a HV 9. |
yrodiere
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Now that main is HV 9, I think we can rebase and merge @marko-bekhta
marko-bekhta
force-pushed
the
remove-security-manager
branch
from
3ed40d6 to
e3e2dd1
Compare
yrodiere
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HV-1975
I've kept the actions as utils classes with static action methods.
There's also
HibernateValidatorPermission, which will not be affected by the removal of the SM itself but, at the same time, becomes useless... since it's in the API, I've only marked it as deprecated and for removal.