Skip to content

HV-431: Retrofitting programmatic constraint API for method constraints #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Jun 9, 2011
Merged

HV-431: Retrofitting programmatic constraint API for method constraints #55

merged 57 commits into from
Jun 9, 2011

Conversation

@gunnarmorling
Copy link
Member

The change comprises the following:

  • Extended programmatic API for method constraints
  • Split programmatic API into internal and public part
  • Several quality improvements (removed raw type warnings etc.)

kevinpollet and others added 30 commits June 2, 2011 11:08
@kevinpollet @gunnarmorling
HV-431 Adding me as developer.
81e2db2
@kevinpollet @gunnarmorling
HV-431 Adding a ConstraintsForProperty class.
3d5d391
@kevinpollet @gunnarmorling
HV-431 Making the valid definition for a property contextual.
2115f50
@kevinpollet @gunnarmorling
HV-431 Adding a ConstraintsForMethod class.
dfce65b
@kevinpollet @gunnarmorling
HV-431 Adding valid definition for method return and parameter.
088a335
@kevinpollet @gunnarmorling
HV-431 Use the grouping programmatic API approach.
204f188
@kevinpollet @gunnarmorling
HV-431 Adding some comments and missing license headers.
dd6a547
@kevinpollet @gunnarmorling
HV-431 Adding ReflectionHelper#getDeclaredMethod().
cb9859e
@kevinpollet @gunnarmorling
HV-431 Adding MethodCascadeDef class.
1c00033
@kevinpollet @gunnarmorling
HV-431 Allow programmatic configuration of cascaded method elements (…
ee88766 
…parameters and return value).
@kevinpollet @gunnarmorling
HV-431 Clean and refactor the programmatic API.
9dd04f6
@kevinpollet @gunnarmorling
HV-431 Fixing error messages.
d87e533
@kevinpollet @gunnarmorling
HV-431 Test cascade of method elements (parameters and return value) …
d0e1c19 
…with the programmatic API.
@kevinpollet @gunnarmorling
HV-431 Adding a new method in CollectionHelper allowing to create an …
f41feec 
…ArrayList from Iterables and cleaning MethodMetaData aggregation.
@gunnarmorling
HV-431: Moving merge logic to model types
b5f15c6
@gunnarmorling
HV-431: New approach with separate constraint configuration
78352e9
@gunnarmorling
HV-431: Refactoring to programmatic method API:
59c8f6a 
* Renaming state types to XyCreationalContext
* Extracting facet interfaces for creational contexts which represent the possible next operations
@gunnarmorling
HV-431: Removing obsolete constructors from constraint definition types
004cd2d
@gunnarmorling
HV-431: Recactoring ConstraintDef et al.:
bd323c4 
* Extracting location related meta data from ConstraintDef to separate type ConfiguredConstraint in order to simplify constraint definition usage
* Removing ConstraintAccessor
@gunnarmorling
HV-431: Extracting interfaces for context types
af02a0a
@gunnarmorling
HV-431: Establishing "context" sub-package
cc582ce
@gunnarmorling
HV-431: Fixing wrong return types
c54c415
@gunnarmorling
HV-431: Checking parameters of public API, adapting test
0b96f50
@gunnarmorling
HV-431: Fixing test failure due to changed invocation checking
2b684f3
@gunnarmorling
HV-431: Formatting
2a869df
@gunnarmorling
HV-431: Fixing failing test due to accidential removal of constraint …
43b06fb 
…group
@gunnarmorling
HV-431: Removing wrong type parameter
9fdbfee
@gunnarmorling
HV-431: Estabishing ConstraintDef#create() and createGeneric()
7ecc327
@gunnarmorling
HV-431: Removing some warnings
773bd29
@gunnarmorling
HV-431: Removing obsolete type parameter from ParameterMetaConstraint
be8afb5
@gunnarmorling
HV-431: Implementing programmatic configuration of parameter constrai…
977e09e 
…nts (work in progress)
@gunnarmorling
HV-431: Parametrizing ConfiguredConstraint with its location type
6d96b15
@gunnarmorling
HV-431: Renaming MethodParameterConstraintLocation to ParameterConstr…
1198fb3 
…aintLocation
@gunnarmorling
HV-431: Simplifying TestUtil
2a5e988
@gunnarmorling
HV-431: Adding support for constraints at several parameters
5f2b4bc
@gunnarmorling
HV-431: Simplifying test
d4c47e4
@gunnarmorling
HV-431: Adding more tests for parameter constraints
88ba9f0
@gunnarmorling
HV-431: Renaming meta model classes from Parameter* to Method* in ord…
52858c4 
…er to use them for return value constraints as well
@gunnarmorling
HV-431: Simplifying creational contexts, pulling parameter checking o…
4d1beb9 
…ut in order to producer clearer stacktraces upon failures
@gunnarmorling
HV-431: Representing return value constraints with MethodMetaConstraint
11708e4
@gunnarmorling
HV-431: Adding some functional bling
85e7a7b
@gunnarmorling
HV-431: Adding tests for return value constraints
a90f38b
@gunnarmorling
HV-431: Removing redundant type parameter declarations
08cd697
@gunnarmorling
HV-431: Using simplified collection instantiation at more places
ba4188a
@gunnarmorling
HV-431: Using *Location for cascaded definitions
bcfc9d0
@gunnarmorling
HV-431: Fixing errors due to rebase
6fdf1ab
@gunnarmorling
HV-431: Using create() for definition instantiation everywhere
2e3052d
@gunnarmorling
HV-431: Removing (Method)ConstraintDef in favor of (Method)Constraint…
bca3ccb 
…Location
@gunnarmorling
HV-431: Removing some warnings, unused imports, unnecessary casts etc.
5e02adf
@gunnarmorling
HV-431: Improving JavaDocs, formatting
aa5dc93
@gunnarmorling
HV-431: Adding missing package.html files. Aligning package descripti…
6cea7fe 
…ons.
@gunnarmorling
HV-431: Adding test for addition of annotion and programmatic field/p…
92661ff 
…roperty constraints
@gunnarmorling
HV-431: Unifying creation of validation proxies in test
625d0f0
@gunnarmorling
HV-431: Describing programmatic constraint configuration of method co…
5556554 
…nstraints in reference guide
@gunnarmorling
HV-431: Extracting constraint mapping context from constraint mapping…
0e18708 
… in order to minimize the public API on ConstraintMapping.
@gunnarmorling
HV-431: Parametrizing type creational context with type of bean in or…
101693d 
…der to make specification of group sequence provider type-safe
@gunnarmorling
HV-431: Renaming mapping context types
ab32e0d
@gunnarmorling
Copy link
Member Author

I think we're now in a state where the remaining questions can be addressed with separate issues. These are:

HV-487 - Settle on an approach for instantiating constraint definitions
HV-485 - Determine an order for the constraint mapping fluent API

@hferentschik hferentschik merged commit ab32e0d into hibernate:master Jun 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gunnarmorling @hferentschik @kevinpollet