HV-546 #95
HV-546 #95
Conversation
…d build warning in hibernate-validator-integrationtest
…per to build custom provider jar as well as bundled hibernate validator jars. Also moving classes into util directory to be easier shared between tests
… list of all bean validation providers. However, other providers are still being processed and used in case explicitly required by eg validation.xml
…faultValidationProviderResolver Also making use of the already existing privileged action classes
There was a problem hiding this comment.
I'm wondering why you use here ArchivePaths.create and in other deployments you use addAsWebInfResource( EmptyAsset.INSTANCE, "beans.xml" ) ?
There was a problem hiding this comment.
No particular reason at all. The setup is a mix of different examples I found (amongst other in Search). Documentation around Shrinkwrap and Arquillian would need some attention IMO. I will align the examples so that we are consistent within Validator
|
I haven't run the tests but looks good! |
There was a problem hiding this comment.
Just a thought I think you can use addAsManifestResource and remove the META-INF part.
…tegrationTestUtil. thanks Kevin for the tip :-)
|
@kevinpollet formatted and fixed the logging version. I tried addAsManifestResource, but that did not work. Haven't really inspected the generated artifacts yet to see where files ended up, but just changing the lines and running the tests is leading to test failures. |
|
I assume that this changes are ok now. Going to merge it into master |
|
rebased and merged |
2 participants
Fixing LazyValidatorFactory implementation. Hibernate Validator will always be the default, but other available providers can pass in case they are explicitly requested.
A lot of changes for something quite simple. However, the functional change is only in LazyValidatorFactory, the rest is only test infrastructure.
The LazyValidatorFactory code should be ported to the corresponding factories in the AS 7 codebase.