HIB-129: Rework the Hibernate Tools landing page to reflect the actual situation #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koen Aers <koen.aers@gmail.com>
gavinking
reviewed
Apr 10, 2025
gavinking
reviewed
Apr 10, 2025
gavinking
reviewed
Apr 10, 2025
gavinking
reviewed
Apr 10, 2025
Member
|
@koentsje looks good, I've left some suggestions. |
yrodiere
reviewed
Apr 10, 2025
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
LGTM overall, thanks! A few suggestions below.
|
|
||
| An editor for Hibernate XML mapping files, supporting auto-completion and syntax highlighting. | ||
| The editor even supports semantic auto-completion for class names, property/field names, table names and column names. | ||
| image::/tools/images/reveng.png[Reverse Engineering] |
Member
There was a problem hiding this comment.
This really can be generated using the Maven/Ant/Gradle plugins? That's awesome.
| ----- | ||
|
|
||
|
|
||
| Of course all these defaults can be overridden and tuned. Please consult the documentation for more information. |
Member
There was a problem hiding this comment.
I imagine we don't have a link? 🙈
Suggested change
| Of course all these defaults can be overridden and tuned. Please consult the documentation for more information. | |
| Of course all these defaults can be overridden and tuned. Please consult https://some.link.org/foo[the documentation] for more information. |
Co-authored-by: Gavin King <gavin@hibernate.org> Co-authored-by: Yoann Rodière <yoann@hibernate.org>
Member
Author
|
The PR was rebased against the production branch with the suggested changes included and merged into production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.