Skip to content

Include required metadata in release artifacts and bump version#27

Merged
ben-m-lucas merged 3 commits intomainfrom
fix-release-artifacts
Dec 26, 2024
Merged

Include required metadata in release artifacts and bump version#27
ben-m-lucas merged 3 commits intomainfrom
fix-release-artifacts

Conversation

@ben-m-lucas
Copy link
Contributor

Describe your changes

This PR:

  • includes the required metadata for our release artifacts and bumps the version

adrummond-hl
adrummond-hl previously approved these changes Dec 26, 2024
wgillett
wgillett previously approved these changes Dec 26, 2024
Copy link

@wgillett wgillett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

sdk/pom.xml Outdated
</parent>
<artifactId>hiddenlayer-sdk</artifactId>
<packaging>jar</packaging>
<name>Java Hiddenlayer SDK</name>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: HiddenLayer Java SDK

@ben-m-lucas ben-m-lucas dismissed stale reviews from wgillett and adrummond-hl via c1034ce December 26, 2024 21:32
@ben-m-lucas ben-m-lucas enabled auto-merge (squash) December 26, 2024 21:33
Copy link

@wgillett wgillett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdk/pom.xml Outdated
<packaging>jar</packaging>
<name>Java Hiddenlayer SDK</name>
<name>Hiddenlayer Java SDK</name>
<description>Java SDK for Hiddenlayer</description>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiddenlayer -> HiddenLayer here and above

@ben-m-lucas ben-m-lucas merged commit 8bbe2fc into main Dec 26, 2024
@ben-m-lucas ben-m-lucas deleted the fix-release-artifacts branch December 26, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants