fix(#124): comments.note_id に外部キー制約と ON DELETE CASCADE を追加する#137
Merged
Conversation
REFERENCES notes(id) ON DELETE CASCADE を追加し、PRAGMA foreign_keys=ON で SQLite の FK 強制を有効化することで、ノート削除時の孤児コメントを防ぐ。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commentsテーブルのnote_idにREFERENCES notes(id) ON DELETE CASCADEを追加@event.listens_for(Engine, "connect")で SQLite のPRAGMA foreign_keys=ONを自動設定ensure_schemaベースに統一し FK 制約を考慮した構成に更新Test plan
Closes #124
🤖 Generated with Claude Code