-
Notifications
You must be signed in to change notification settings - Fork 109
test: add unit tests for crypto_utils (Issue #993) #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit tests for crypto_utils (Issue #993) #1006
Conversation
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! From the Hiero Python SDK Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive unit tests for the crypto_utils module to address issue #993, covering keccak256, compress_point_unchecked, decompress_point, and compress_with_cryptography functions. The PR also includes an enhancement to the Good First Issue template by adding an Acceptance Criteria section.
- Adds 4 unit test functions covering cryptographic utility functions with known test vectors and round-trip validation
- Enhances the Good First Issue template with standardized acceptance criteria
- Updates CHANGELOG formatting (though introduces some issues that need correction)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/unit/crypto_utils_test.py | New comprehensive test suite for crypto_utils module with test cases for keccak256 hashing, point compression/decompression, and validation against known vectors |
| CHANGELOG.md | Formatting updates and whitespace changes (missing entry for #993, contains formatting issues) |
| .github/ISSUE_TEMPLATE/01_good_first_issue.yml | Adds Acceptance Criteria section to improve contributor guidance with clear merge requirements checklist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
823d8e7 to
98aa8df
Compare
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you make sure you always create a fork from an updated main, that is in sync with the upstream main
Otherwise you will get odd artefacts on your changelog and etc which hold you back :)
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow docs/sdk_developers/rebasing.md, pull all changes from upstream, rebase your branch
and then add a changelog entry please just with your change
Else the tests will fail :(
|
Just changed it to draft while you make the tweaks, pelase click ready to review once its ready again :) |
98aa8df to
27a104f
Compare
|
request review @tech0priyanshu if able |
|
Request review @AntonioCeppellini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @adityashirsatrao007 what do you think of the copilot feedback? edit: marking as draft while you apply changes and mark it ready to review again |
27a104f to
3e36344
Compare
0a2de6e to
a66e0a6
Compare
Done |
tech0priyanshu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @adityashirsatrao007 , for this contribution! 🎉 Please make the update, and then we’ll be ready to go.
3b67e65 to
8aa283c
Compare
|
Implemented Copilot suggestions:
Check updated code. |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adityashirsatrao007
note when using tools, they are often not signature attached so you can lose sign status if you use them
Please follow instructions here to rectify
https://github.com/hiero-ledger/hiero-sdk-python/pull/1006/checks?check_run_id=57655613240
Else you can do a soft revert and recommit
d1d5713 to
6d5e74e
Compare
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
6d5e74e to
0fdd761
Compare
|
Thank you, great going @adityashirsatrao007 ! |
Fixes #993. Adds unit tests for keccak256, compress_point, and decompress_point in crypto_utils.py.