gitlab: fix check for batched background migrations #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gitlab::BackgroundMigration.remaining method that was used in earlier versions to check for pending background migrations has been removed. Replace the deprecated method with the new batched background migrations API. It returns `0` when all background migrations are complete. Signed-off-by: Norman Ziegner <n.ziegner@hzdr.de>
christianhueserhzdr
approved these changes
Nov 28, 2025
Member
christianhueserhzdr
left a comment
christianhueserhzdr
left a comment
There was a problem hiding this comment.
This is all fine, thanks a lot for the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Gitlab::BackgroundMigration.remainingmethod that was used in earlier versions to check for pending background migrations has been removed. Replace the deprecated method with the new batched background migrations API.It returns
0when all background migrations are complete.