Skip to content

Ensure new default branch main is used by Galaxy #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2022
Merged

Ensure new default branch main is used by Galaxy #64

merged 2 commits into from
Dec 2, 2022

Conversation

@Normo
Copy link
Member

@Normo Normo commented Dec 1, 2022

@Normo Normo added this to the v2.0.0 milestone Dec 1, 2022
@Normo Normo self-assigned this Dec 1, 2022
@Normo Normo force-pushed the 13-default-branch-main branch from c9dd2d7 to 103afbc Compare December 1, 2022 14:37
tobiashuste
tobiashuste requested changes Dec 2, 2022
View reviewed changes
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github_branch is only valid for collection metadata as far as I know. Ansible-lint also complains.

We should probably update this line instead:

https://github.com/hifis-net/ansible-role-unattended-upgrades/blob/9032da93066376d4dbd56f9f7a11455b477eb2c5/.github/workflows/ci.yml#L74

Specify the new default branch that Galaxy will use for this role
be78d72 
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
@Normo Normo force-pushed the 13-default-branch-main branch from 103afbc to be78d72 Compare December 2, 2022 09:47
@Normo Normo requested a review from a team as a code owner December 2, 2022 09:47
@Normo
Copy link
Member Author

Normo commented Dec 2, 2022

@tobiashuste Strange, then the Galaxy documentation seems to be inconsistent.

@Normo Normo requested a review from tobiashuste December 2, 2022 09:49
@tobiashuste
Copy link
Member

tobiashuste commented Dec 2, 2022

@tobiashuste Strange, then the Galaxy documentation seems to be inconsistent.

You're right, @Normo!

It could be that standalone: true fixes the ansible-lint complaints. See https://ansible-lint.readthedocs.io/rules/schema/#schema-meta.

Mark role as standalone
86edf5a 
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
@Normo Normo changed the title Add github_branch to role meta information Ensure new default branch main is used by Galaxy Dec 2, 2022
tobiashuste
tobiashuste approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Normo 👍

Feel free to merge once the pipeline succeeded.

@Normo Normo merged commit 724b8df into hifis-net:main Dec 2, 2022
@Normo Normo deleted the 13-default-branch-main branch December 2, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiashuste tobiashuste tobiashuste approved these changes

@christianhueserhzdr christianhueserhzdr Awaiting requested review from christianhueserhzdr

Assignees

@Normo Normo

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

Rename default branch to main

2 participants

@Normo @tobiashuste