Skip to content

Conversation

@hcpchris
Copy link
Collaborator

Fixed #67 . Now when .from_array() is called to construct a data point and:

  • the array does not explicitly indicate property values, AND
  • the x value in the array is a string
    the x value is also propagated into the data point's name property.

@hcpchris hcpchris added this to the v.1.2.4 milestone Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #68 (d1010ad) into develop (88a802b) will decrease coverage by 0.03%.
The diff coverage is 8.33%.

@@             Coverage Diff             @@
##           develop      #68      +/-   ##
===========================================
- Coverage    90.31%   90.28%   -0.03%     
===========================================
  Files          206      206              
  Lines        27495    27507      +12     
  Branches      1786     1792       +6     
===========================================
+ Hits         24831    24834       +3     
- Misses        1974     1982       +8     
- Partials       690      691       +1     
Files Changed Coverage Δ
highcharts_core/options/series/data/bar.py 80.43% <0.00%> (-0.71%) ⬇️
highcharts_core/options/series/data/boxplot.py 78.72% <0.00%> (-1.14%) ⬇️
highcharts_core/options/series/data/bullet.py 64.70% <0.00%> (-1.97%) ⬇️
highcharts_core/options/series/data/range.py 80.00% <0.00%> (-0.99%) ⬇️
highcharts_core/options/series/data/cartesian.py 72.32% <25.00%> (+0.04%) ⬆️

@hcpchris hcpchris merged commit 98d4efb into develop Jul 25, 2023
@hcpchris hcpchris deleted the BUG/67-x-axis-as-category-strings branch July 25, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants