Skip to content

require('uuid/v4') requires uuid 3.0.1+#25

Merged
cvasseng merged 1 commit into
highcharts:masterfrom
Innovu:uuid-dep
Feb 13, 2017
Merged

require('uuid/v4') requires uuid 3.0.1+#25
cvasseng merged 1 commit into
highcharts:masterfrom
Innovu:uuid-dep

Conversation

@tonylukasavage
Copy link
Copy Markdown
Contributor

The require('uuid/v4') call absolutely requires node-uuid 3.0.1+. Calling the API in that manner was introduced in 3.0.1. Because the dependency in node-export-server is defined as "uuid": "*", that require will fail when this module is installed along side ANY other module that has a stricter uuid dependency that resolves lower than 3.0.1 (as it does in my case).

A simple example would be dependencies that look like this:

"dependencies": {
  "highcharts-export-server": "*",
  "uuid": "^1.4.0"
}

An npm/yarn install will install node-uuid 1.4.X, and then highcharts-export-server will throw the error Cannot find module 'uuid/v4'.

@cvasseng cvasseng merged commit 54dba5f into highcharts:master Feb 13, 2017
@cvasseng
Copy link
Copy Markdown
Contributor

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants