Merged
Conversation
cvasseng
requested changes
Jan 10, 2024
PaulDalek
approved these changes
Jan 11, 2024
cvasseng
approved these changes
Jan 12, 2024
This was referenced Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue: highcharts/highcharts#20370
The problem
The
exporting.filenameoption in Highcharts allowed users to change the name of the exported file. Since v3, this option stopped working.The solution
Need to export a file with the
filenamespecified inrequest.body(the same way as it was done in Phantom) and include this information clearly in the documentation.