make AttributePhaseChange available for DataSets and files. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@radistmorse Thank you, I've added a commit with tests, and a small fix to make it possible to read the attribute phase change related values from the two newly supported property lists. If CI passes we'll, I propose to "squash and merge", which should make you the author. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since attributes can be added to both groups and datasets, there is no point to make AttributePhaseChange exclusive to GroupCreateProps. Technically, H5Pset_attr_phase_change/H5Pget_attr_phase_change are from OCPL, which makes them eligible for ObjectCreateProps, FileCreateProps and DataSetCreateProps. But since ObjectCreateProps is not really used anywhere, only the other two really make sense. Attributes could be added to both DataSets and files (which is the same as adding them to the root group), so the ability to set the phase change for them is also logical.