Skip to content

fix: model sdk tests#214

Merged
abhijitjavelin merged 3 commits intomainfrom
fix_sdk_issues
Jul 23, 2025
Merged

fix: model sdk tests#214
abhijitjavelin merged 3 commits intomainfrom
fix_sdk_issues

Conversation

@abhijitjavelin
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @abhijitjavelin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on fixing issues related to model SDK tests by standardizing the API key header used in various example configurations and refining the Javelin SDK's client setup. The changes ensure consistent and correct API key transmission and proper base URL handling, especially for Azure OpenAI services.

Highlights

  • API Key Header Standardization: The x-api-key header has been consistently updated to x-javelin-apikey across all example configurations for Azure OpenAI, Bedrock, and general OpenAI clients. This ensures proper authentication and communication with the Javelin API.
  • Javelin SDK Client Refinement: The javelin_sdk/client.py has been modified to remove the x-javelin-provider header, streamlining the custom header setup for OpenAI clients.
  • Azure OpenAI Base URL Correction: Logic has been added to the Javelin SDK's register_provider method to automatically append /openai to the base URL for Azure OpenAI providers if it's not already present. This ensures correct endpoint resolution for Azure OpenAI services.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request primarily updates the API key header from x-api-key to x-javelin-apikey across various example files. There is a critical issue where a debug print statement has been left in the code, and a high severity issue concerning the removal of automatic x-javelin-provider header injection.

@abhijitjavelin abhijitjavelin merged commit 3a26fab into main Jul 23, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants