Skip to content

fix: model sdk e2e tests#215

Merged
abhijitjavelin merged 2 commits intomainfrom
fix_modelsdk_tests
Jul 28, 2025
Merged

fix: model sdk e2e tests#215
abhijitjavelin merged 2 commits intomainfrom
fix_modelsdk_tests

Conversation

@abhijitjavelin
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @abhijitjavelin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to fix end-to-end tests for the model SDK by refining how various AI clients (Azure OpenAI, Bedrock, and OpenAI) are configured and interact with the Javelin platform. The changes standardize API base URLs, clarify Bedrock routing mechanisms, and ensure that model calls correctly utilize actual model IDs, leading to more robust and reliable test execution.

Highlights

  • Azure OpenAI Client Configuration: Explicitly set base_url="" for the AzureOpenAI client initialization in the azure-universal.py example. This ensures the client correctly routes requests through Javelin without an unintended default base URL.
  • Bedrock Client Registration and Routing: Added bedrock_session=None and route_name="amazon" parameters during the javelin_client.register_bedrock call in bedrock_client_universal.py. Additionally, bedrock_general_route.py now includes an x-javelin-route header with value "amazon" for Bedrock API calls, and the converse and invoke functions are updated to use actual Bedrock model_ids (e.g., "anthropic.claude-v2") instead of Javelin-specific route names.
  • OpenAI Base URL Standardization: Simplified the base_url for both synchronous and asynchronous OpenAI clients in openai_general_route.py from a specific /v1/query/openai path to a more general /v1. This streamlines the API endpoint configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates example files to fix model SDK end-to-end tests, including API endpoint URL updates, client initialization parameter modifications, and variable renaming for clarity. The changes address the necessary fixes for the tests, with comments added to enhance code clarity and maintainability.

@abhijitjavelin abhijitjavelin merged commit a8cedc3 into main Jul 28, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants