fix: update dependency constraints for security alerts#229
Conversation
Summary of ChangesHello @ankumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the project's security by updating the version constraints for key Python dependencies, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to update urllib3 and requests dependencies to address security alerts. While the intent is correct, the changes are made in poetry.toml, which is not the standard file for defining dependencies in a Poetry project. This means the security fixes are likely ineffective. The correct approach is to update the dependency constraints in pyproject.toml, run poetry lock to update the lock file, and commit both files. The current use of poetry.toml for dependencies is a critical issue that needs to be addressed to ensure the project's dependencies are managed correctly and securely.
Moved security dependency constraints from poetry.toml to pyproject.toml where they belong. Poetry uses pyproject.toml for dependency management, and the [tool.poetry.dependencies] section in poetry.toml is non-standard and ignored by Poetry. Changes: - Updated requests to ^2.32.3 in pyproject.toml - Added urllib3 >=2.2.2,<3.0.0 as explicit dependency in pyproject.toml - Removed invalid [tool.poetry.dependencies] section from poetry.toml - Updated poetry.lock with secure versions (requests 2.32.5, urllib3 2.5.0) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
No description provided.