Conversation
|
…erformance-data-not-being-collected-correctly
Releases: highlight.run@9.2.2 @highlight-run/next@7.5.20 @highlight-run/react@4.0.2 @highlight-run/remix@2.0.51 [skip ci]
SpennyNDaJets
approved these changes
Aug 13, 2024
…erformance-data-not-being-collected-correctly
giraffekey
pushed a commit
to giraffekey/highlight
that referenced
this pull request
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We are seeing a number of failed requests trying to send OTEL data for traces from the browser to our collector (example in screenshot).
This change adds a new exporter that attempts to send data using the existing exporter and falls back to submitting the request via XHR if it fails.
How did you test this change?
Was able to confirm failed requests were being caught and retried via XHR by examining the network traffic in dev tools (see screenshot).
Are there any deployment considerations?
Nothing major, but I will validate that metrics coming from the document load listener have more data reported after this goes out.
Does this work require review from our design team?
N/A