Fix RangeError when decoding base64 #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a
RangeError: Invalid array lengtherror that can be thrown when decoding a Base64Binary.It may also be worth to look into the latest version of the
Base64Binarycode that this was based on, and which is available here (and that was first introduced in this blog post).Edit: On closer inspection, the value that I was trying to decode seems to be truncated/incomplete. Still, it may be worth to update the
Base64Binarycode to the one that I have linked to, as jsonix currently fails with an unclear error if can't decode a base64 value. For reference, this is the "weird" base64 value that I was trying to decode:BwABBJQ1gJDUCAAAAAAA=