Optimization Under Uncertainty #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… then some stress testing
…laborious and orthogonal effort. it will be made into an issue.
…iable. Have not tested it yet
…ound AS batch size
Member
Author
|
Should we add evaluation helper arrays to |
…e for KLE specifically
…versions. Same as int.
dc-luo
requested changes
Jun 13, 2023
| if control_jacobian: | ||
| self.Jz = ObservableControlJacobian(self.observable) | ||
| output_dimension,control_dimension = self.Jz.shape | ||
| control_rank = min(self.parameters['jacobian_rank'],output_dimension,control_dimension) |
Collaborator
There was a problem hiding this comment.
Should this be self.parameters['control_jacobian_rank']
hippyflow/modeling/observable.py
Outdated
| elif component == ADJOINT: | ||
| elif component == hp.ADJOINT: | ||
| x = self.problem.generate_state() | ||
| elif component == 3: |
Collaborator
There was a problem hiding this comment.
I think CONTROL is defined in this file. Let's use that instead of 3
dc-luo
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for optimization problems, where there is an additional paramter
zthat is optimized in expectation over the distribution of parameterm, e.g., the prior