Skip to content

Trying to fix imagick install #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SilverFire merged 1 commit into from
Nov 27, 2024
Merged

Trying to fix imagick install #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/8.4/fpm-alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ ENV PHP_POST_MAX_SIZE=60M
ENV PHP_UPLOAD_MAX_FILESIZE=25M
ENV PHP_SESS_GC_MAXLIFETIME=2592000

COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/local/bin/

RUN set -xe \
&& apk update \
&& apk add --no-cache --virtual .php-deps \
Expand Down Expand Up @@ -74,8 +76,7 @@ RUN set -xe \
docker-php-ext-install zip bcmath soap pcntl gmp && \
docker-php-ext-enable mailparse imap && \

pecl install imagick && \
docker-php-ext-enable imagick && \
install-php-extensions Imagick/imagick@65e27f2bc0 && \
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Consider updating to the latest stable version 3.7.0

The commit hash 65e27f2bc0 appears invalid or no longer exists, but there is a stable release version 3.7.0 available. I recommend updating the installation line to use this stable version tag instead:

install-php-extensions Imagick/imagick@3.7.0 && \

This change will:

  • Ensure reproducible builds with a well-tested release
  • Improve maintainability with clear version tracking
  • Prevent potential issues with commit hash references
🔗 Analysis chain

Consider using a stable version tag instead of commit hash

While pinning to a specific commit (65e27f2bc0) ensures reproducible builds, using a stable version tag would be more maintainable and less prone to issues if the repository history is rewritten.

Let's verify if there's a stable release tag available:

Let me try a different approach to verify the commit and available tags.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if there's a stable release tag for the imagick extension
# that corresponds to or is newer than the specified commit

# Clone the repository and check tags
git clone https://github.com/Imagick/imagick.git /tmp/imagick
cd /tmp/imagick
git tag --contains 65e27f2bc0 | grep -E '^[0-9]+\.[0-9]+\.[0-9]+$' || echo "No stable version found containing this commit"

Length of output: 386

Script:

#!/bin/bash
# Let's verify if this is the correct repository and check available tags
gh repo view Imagick/imagick --json description,url

# Check recent tags
gh api repos/Imagick/imagick/tags --paginate | jq -r '.[].name' | head -n 5

Length of output: 264


# SSH
pecl install ssh2-$PECL_SSH2_RELEASE && \
Expand Down
2 changes: 1 addition & 1 deletion src/8.4/fpm-alpine/hiqdev-docker-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ if [ "$ENV" != "prod" ]; then
sed -i "s/xdebug.client_port\s*=\s*.*/xdebug.client_port=$XDEBUG_CLIENT_PORT/" /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
fi
if [ -n "$XDEBUG_START_WITH_REQUEST" ]; then
echo "[ xdebug ] Set xdebug.remote_autostart to $XDEBUG_START_WITH_REQUEST"
echo "[ xdebug ] Set xdebug.start_with_request to $XDEBUG_START_WITH_REQUEST"
sed -i "s/xdebug.start_with_request\s*=\s*.*/xdebug.start_with_request=$XDEBUG_START_WITH_REQUEST" /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
fi
fi
Expand Down