Refactor event/pending event, and add a way to immediately commit an event#27
Merged
Refactor event/pending event, and add a way to immediately commit an event#27
Conversation
Contributor
Author
|
OK, I feel much happier with things now that the results are handled elsewhere. I'm pretty sure that the metadata handler can also be used to work on #14 — I'm going to pair with @skylerkatz later today on that, hopefully! |
inxilpro
changed the title
fireNow method
Collaborator
|
This looks much cleaner than the initial rounds. Now you just need to update the |
inxilpro
changed the title
fireNow methodReplaced the 'fireAndCommit' method name with 'commit' across multiple files for better readability and simplicity. This change is reflected in the 'Event', 'Support/helpers' and 'Support/PendingEvent' files, along with relevant modifications in associated tests..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did this on the last livestream. It moves the
fireandmakemethods to mostly just defer to thePendingEventimplementation. It also introduces a newfireNow()method that allows for firing an event and immediately receiving the result of that event'shandle()method. This should ease the "how to handle a 'create'-type request, where you want to use the model immediately" question.I'm leaving as draft because I'm not 100% sure about the recursive
WeakMapportion. Mulling it over…