Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently using the Symfony
ObjectNormalizerwhich is a little over-eager to deserialize data via methods. This means that if your state has a method with the same name as a property, that can cause problems…This PR moves to the less-aggressive
PropertyNormalizer, which should be good for almost everyone. It also makes the normalization pipeline configurable, if you want to register your own normalizers.That said, we may look to implement our own serialization system that either is a fork of Livewire synths or at least plays nicely with synths—so this could just be a stop-gap measure.
I'm not 100% sure, but this could also help address #43.