Chore: update rosetta dockerfile #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This close to a full rewrite of the built image. - runit is removed - `/entrypoint.sh` now starts all processes via single script - all logs are piped to stdout - remove printf in favor of heredoc - add a script to seed the chainstate when env var `SEED_CHAINSTATE=true` - adds a postgres init script in case of genesis sync and DB != `postgres`
Codecov Report
@@ Coverage Diff @@
## develop #1651 +/- ##
========================================
Coverage 78.13% 78.13%
========================================
Files 79 79
Lines 11241 11241
Branches 2495 2495
========================================
Hits 8783 8783
Misses 2344 2344
Partials 114 114 |
zone117x
reviewed
May 10, 2023
zone117x
reviewed
May 10, 2023
zone117x
reviewed
May 10, 2023
Contributor
zone117x
left a comment
zone117x
left a comment
There was a problem hiding this comment.
Oh there's also a few references to the file that need to be updated with the rename, this CI build in particular here:
The others are in markdown docs
Contributor
Author
got it - i'll address when i make the other changes |
updating docs where stx-rosetta is used add some docs around `SEED_CHAINSTATE` add -W to pg_ctl and removing sleep
zone117x
approved these changes
May 19, 2023
Contributor
|
🎉 This PR is included in version 7.2.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 7.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This close to a full rewrite of the built image. The filename is also changed to a more appropriate
rosetta.Dockerfile/entrypoint.shnow starts all processes via single scriptSEED_CHAINSTATE=truepostgresType of Change
Does this introduce a breaking change?
N/A
Testing information
Tested by building the docker image and launching with:
In all cases, the chain progressed - of note, seeding the chainstate by supplying the env var:
SEED_CHAINSTATE=trueonly works if the archives for the defined versions exists (at this moment, there is not 2.3.0.0.2 archive available, but was tested with 2.3.0.0.1). Also note that the time to process an archive can be highly variable depending on the system.The other caveat to this change is that when
SEED_CHAINSTATE=true, the container will need to be launched with--shm-size.ex:
--shm-size=256MBElse, postgres will crash with an error regarding "out of space" (this applies to memory, not disk. details here: https://stackoverflow.com/questions/56751565/pq-could-not-resize-shared-memory-segment-no-space-left-on-device )