Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the project's build tooling from a traditional Make-based approach to mise for dependency management and task orchestration. The change introduces mise for bootstrapping development tools (xcbeautify, xcodes) and standardizes task execution across local development and CI environments.
Key Changes:
- Replaced Makefile with mise.toml for task definitions and tool management
- Migrated build script from build.sh to build.bash with improved error handling and debug support
- Updated GitHub Actions workflow to use mise-action for consistent tooling
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/build.sh | Removed old shell script in favor of new build.bash |
| scripts/build.bash | New build script with enhanced error handling, debug tracing, and environment variable support |
| mise.toml | Added mise configuration for tool management (xcbeautify, xcodes) and task definitions (bootstrap, build, clean) |
| Makefile | Removed in favor of mise.toml task definitions |
| .github/workflows/build.yml | Updated to use mise-action and expanded trigger conditions to include workflow_dispatch and release branches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| function main() { | ||
| xcrun xcodebuild build \ | ||
| -scheme "CenterMouse" \ | ||
| -derivedDataPath "${PROJECT_ROOT}/DerivedData" \ |
There was a problem hiding this comment.
The -clonedSourcePackagesDirPath parameter was removed from the xcodebuild command. This was present in the original build.sh script and may be necessary for package dependency management. Verify this removal is intentional, or add it back: -clonedSourcePackagesDirPath \"${PROJECT_ROOT}/DerivedData/Packages\"
| -derivedDataPath "${PROJECT_ROOT}/DerivedData" \ | |
| -derivedDataPath "${PROJECT_ROOT}/DerivedData" \ | |
| -clonedSourcePackagesDirPath "${PROJECT_ROOT}/DerivedData/Packages" \ |
| fi | ||
|
|
||
| function main() { | ||
| xcrun xcodebuild build \ |
There was a problem hiding this comment.
The clean operation was removed from the xcodebuild command (original was clean build). This means builds will no longer clean before building by default. Consider whether this is intentional or if clean should be added back to ensure consistent builds.
| xcrun xcodebuild build \ | |
| xcrun xcodebuild clean build \ |
No description provided.