Skip to content

Add AMQPExchange and support AMQPQueue binding to an exchange#44

Closed
joao-conde wants to merge 6 commits intohivesolutions:masterfrom
joao-conde:master
Closed

Add AMQPExchange and support AMQPQueue binding to an exchange#44
joao-conde wants to merge 6 commits intohivesolutions:masterfrom
joao-conde:master

Conversation

@joao-conde
Copy link
Contributor

@joao-conde joao-conde commented Dec 3, 2020

Issue: https://github.com/ripe-tech/ripe-compose/issues/68

This PR:

  • adds an AMQPExchange class that abstracts a connection to a RabbitMQ exchange
  • an exchange belongs to a cluster, not a single node; hence, this class accepts a list of broker URLs; if the connection to one fails, it attempts to connect to the rest; if all brokers fail, this class will attempt to reconnect forever (but such a catastrophic failure will likely require a cluster reset regardless)
  • changes AMQPQueue class to accept an optional exchange name and routing key; if present, it binds the queue to that exchange using that routing key

@coveralls
Copy link

coveralls commented Dec 3, 2020

Coverage Status

Coverage decreased (-0.1%) to 63.718% when pulling de9f12b on joao-conde:master into ad27856 on hivesolutions:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 63.727% when pulling 606f7eb on joao-conde:master into ad27856 on hivesolutions:master.

@joao-conde joao-conde changed the title Add AMQPExchange and support AMPQQueue binding to an exchange Add AMQPExchange and support AMQPQueue binding to an exchange Jan 20, 2021
@joao-conde
Copy link
Contributor Author

Forgot to tag back then @joamag

@joamag joamag self-assigned this Jan 24, 2021
@joamag joamag added enhancement New feature or request risky ❕ Seems to be risky p-medium Medium priority issue labels Jan 24, 2021
@joao-conde
Copy link
Contributor Author

@joamag probably worth to reaper this

@joao-conde joao-conde closed this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request p-medium Medium priority issue risky ❕ Seems to be risky

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants